On Wed, Jul 31, 2013 at 8:17 PM, Stefan Seefeld <[email protected]> wrote: > On 07/31/2013 06:00 PM, Jérémie Galarneau wrote: >> Hi Stefan, >> >> Please inline your patches in the future as it makes the review process >> simpler. >> There are a number of stylistic problems, mostly misplaced braces. >> >> You can run your patches through the checkpatch.pl script found in >> lttng-tools/extras. It will spot most coding-style related problems >> right away. > > OK, will do, once the patch is approved functionally. > >> Also, I think lttng-ust-pthread-mutex.c may be a more appropriate name >> than pthread.c > > Wouldn't that just be redundant ? (And I actually expect the file to > grow instrumentation that's not mutex-specific.)
I'd keep the file name in line with what's already there, namely lttng-ust-malloc.c. If you plan on instrumenting other parts of the pthread API, lttng-ust-pthread.c would make sense. > > Thanks, > Stefan > > -- > > ...ich hab' noch einen Koffer in Berlin... > > > _______________________________________________ > lttng-dev mailing list > [email protected] > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
