On Sat, Oct 29, 2011 at 3:28 PM, Peter Odding <[email protected]> wrote:
>> I don't think distro maintainers would be too happy with this. Suppose
>> I wanted to build a Fedora package of your project. It shouldn't
>> install other Fedora packages by itself. Instead, the dependencies
>> should be in your package's .spec file.
>
> I hadn't considered this issue.
>
>> I understand your effort to make everything automatic with a single
>> command, but I don't think users will expect running a makefile
>> through luarocks to go and install, say, systemwide Debian packages on
>> their system.
>>
>> If you want to provide the automagic functionality for users that
>> desire it, it's your call, but please provide a make target that skips
>> those steps and constrains itself to installing your module, so we can
>> use it in LuaRocks. Installing a rock must not cause the installation
>> of anything outside the rock tree.
>
> Forgive me one last try before I give up on the idea: What if the
> default was to not install any system wide packages but just run the
> check and print a message suggesting to the user that they install the
> missing packages?

Failing and printing a message with instructions is fine. I think it's
the best direction to go.

> Maybe it would also be acceptable if the user has to set a specific
> environment variable before the makefile is permitted to install missing
> system packages? I could then tell users to run the following command if
> they want to have missing packages installed automatically:
>
>        LUA_APR_INSTALL_DEPS=yes luarocks install lua-apr

This has issues with permissions; what if the user is installing
lua-apr unpriviledged? You can't assume you know the user's sudo
setup. If you know what packages need to be installed, you might as
well print a message telling them to run something like:

   sudo apt-get install apr-1 libfoo libbar

or "yum", or whatever their system uses. It's friendly enough (someone
using a command-line to install lua-apr through luarocks will
certainly be comfortable with invoking their package manager to
fulfill a dependency).

-- Hisham

------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook 
in minutes. BlackBerry App World&#153; now supports Android&#153; Apps 
for the BlackBerry&reg; PlayBook&#153;. Discover just how easy and simple 
it is! http://p.sf.net/sfu/android-dev2dev
_______________________________________________
Luarocks-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/luarocks-developers

Reply via email to