Hi Hisham,
On Mon, Jun 9, 2014 at 3:47 PM, Hisham <h...@hisham.hm> wrote:
> [snip]
> >
> > I have forked it
> >
> > https://github.com/rjpcomputing/luazip
> >
> > I committed the changes and updated the version number where I found it
> > (docs, _VERSION, etc)
> >
> > I tagged the release as 'v1_2_4' keeping with the other releases.
> > --
> > Regards,
> > Ryan
> >
> > P.S. I am not really signing up to maintain this module am I? I really
> don't
> > use the functionality much so I am not familiar with the code, but I
> have no
> > issue with this simple change.
>
> Well, not any more than the previous developers who are MIA, anyway. :)
>
> I thought it would be best if the code lives in your repository since
> you're at least using it, so if any other issues like this one comes
> up (ie, something in the ecosystem breaks the build again), you're
> likely to notice it first and then it's easiest for you to tweak and
> push an update.
>
> I predict this will sit at version 1.2.4 for years to come, though!
> (It's been sitting idle since 2007 after all!)
>
Good point.
> > P.P.S. I do have another library I would like to get a rockspec made
> for, so
> > I would like to see how you make this new rockspec so I can copy it. (Use
> > the best practices cause I am going to do it like you. ;) But it is a Lua
> > only library, so mo make file or "building" required.)
>
> Here, I submitted a pull request:
>
> https://github.com/rjpcomputing/luazip/pull/1/files
Great thanks. Applied the pull request.
> [snip]
To make a Lua-only module, just replace the table from the
> build.modules.foo with a simple string with the file path, like this:
>
> build = {
> type = "builtin",
> modules = {
> foo = "src/foo.lua",
> ["foo.bar"] = "src/foo/bar.lua",
> }
> }
>
> and you can of delete the external_dependencies section. If you're
> depending on other rocks, add them to the dependencies section, like
> this:
>
> dependencies = {
> "lua >= 5.1",
> "luasocket",
> "lpeg >= 0.12",
> }
>
Thanks. I will make that one work after I work out the issues with
rocks.moonscript.org and LuaZip.
--
Regards,
Ryan
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Luarocks-developers mailing list
Luarocks-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/luarocks-developers
