Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index MultiReader.java FilterIndexReader.java IndexReader.java SegmentReader.java

[Doug Cutting]

Christoph,

Thanks again for all of your work.  This is a great patch.

One nit, however:

[EMAIL PROTECTED] wrote:
  +  protected IndexReader(Directory directory, SegmentInfos segmentInfos, boolean closeDirectory) {
The non-public SegmentInfos makes an appearance here in a public API. 
Perhaps this constructor should be package-private.

Or perhaps, since the SegmentInfos instance is only used once on line 
414, for version checking, we should instead add an abstract 
getVersion() method implemented by subclasses.  Could that work?

Thanks again,

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]