Christoph,
Thanks again for all of your work. This is a great patch.
One nit, however:
[EMAIL PROTECTED] wrote:
+ protected IndexReader(Directory directory, SegmentInfos segmentInfos, boolean closeDirectory) {
The non-public SegmentInfos makes an appearance here in a public API. Perhaps this constructor should be package-private.
Both constructors of IndexReader or at least the one with SegmentInfos should be made package-private. Thats probably better than protected.
Or perhaps, since the SegmentInfos instance is only used once on line 414, for version checking, we should instead add an abstract getVersion() method implemented by subclasses. Could that work?
Donīt know exactly what you mean here. We already have the getCurrentVersion method in IndexReader, but you probably mean something else.
Do you agree to the changes concerning the bahavior of undeleteAll and close?
Christoph
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
