Please don't reply to lustre-devel. Instead, comment in Bugzilla by using the 
following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11463

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]


(In reply to comment #0)
> [Selected Security component - change as appropriate]
> 
> We have the following initial problem report from a customer:
> 
> The command "lfs quotachown <file system>" deletes all security relevant 
> setuid
> bits, i.e. changes some file mode bits.
> 
> Fergal.      

The "lfs quotachown <filesystem>" performs a chown syscall on each file 
of the filesystem with their original uid/gid, so the setuid bits is
definitely cleared.

I think it's not necessary to clear these bits on the chown which just setting
the original uid/gid again. There are two ways to improve it:
 - "lfs quotachown" stat each file before chown then set back the bits after
   chown.
 - mds_reint_setattr() doesn't clear the suid/sgid bit for the chown which 
   just changing uid/gid to original one.
I prefer the second way. Green, how do you think about?

_______________________________________________
Lustre-devel mailing list
[email protected]
https://mail.clusterfs.com/mailman/listinfo/lustre-devel

Reply via email to