On Jun 08, 2007  14:04 -0400, Weikuan Yu wrote:
> This is the MPICH2 patch I originally started as a base for some ROMIO 
> optimizations over Lustre. It should work fine for MPICH2-1.0.3 on 
> experimental systems. However, use it as your risk :)
> 
> Given time, I will try to push out my optimizations after some cleanup. I 
> would very happy to hear feedbacks on what features people would need most 
> at the time.

Would you object to me adding this patch to the lustre/contrib directory
in the lustre distribution?

Also, are there any plans to include this into an MPICH distribution?  I
think a lot of Lustre users would be happy to see that.

Other notes - in about Lustre 1.6.2 it will be possible to use the FIEMAP
ioctl to help in efficiently preallocating space in the file for the 
ADIO_FCNTL_SET_DISKSPACE fcntl.  That will avoid the need to read the
whole file, and instead just get a list of allocated and unallocated
extents back.



As an aside, it's too bad that the ADIO code is such a mess of #ifdefs.
I suspect much of it could be cleaned up by having proper arch-specific
macros/helper functions to wrap the internals.

> +#ifdef HAVE_STATUS_SET_BYTES
> +    if (done && ((*request)->nbytes != -1))
> +     MPIR_Status_set_bytes(status, (*request)->datatype, (*request)->nbytes);
> +#endif

For example, this could be wrapped in a header and then each ADIO_* driver
does not need to worry if HAVE_STATUS_SET_BYTES is set or not.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

_______________________________________________
Lustre-discuss mailing list
[email protected]
https://mail.clusterfs.com/mailman/listinfo/lustre-discuss

Reply via email to