On Jun 08, 2007 17:21 -0400, Weikuan Yu wrote: > Andreas Dilger wrote: > >As an aside, it's too bad that the ADIO code is such a mess of #ifdefs. > >I suspect much of it could be cleaned up by having proper arch-specific > >macros/helper functions to wrap the internals. > > > >>+#ifdef HAVE_STATUS_SET_BYTES > >>+ if (done && ((*request)->nbytes != -1)) > >>+ MPIR_Status_set_bytes(status, (*request)->datatype, > >>(*request)->nbytes); > >>+#endif > > > >For example, this could be wrapped in a header and then each ADIO_* driver > >does not need to worry if HAVE_STATUS_SET_BYTES is set or not.
> As for the #ifdef, part of it is because the inheritance from other > components. That does not mean ADIO_lustre needs to be the same way though. > I will update you on this further. While I agree in principle, I'd also prefer not to make the ADIO Lustre driver significantly different from the UFS driver without good reason because it means it is harder to incorporate changes from the other drivers. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. _______________________________________________ Lustre-discuss mailing list [email protected] https://mail.clusterfs.com/mailman/listinfo/lustre-discuss
