> Hello! Hi Andriy, > Since lxpanel is GLib/GTK application I would suggest to use GThread and > GCancellable APIs, better don't call pthreads directly. And mentioned > pthread_kill() is not reliable operation which may cause problems in some > cases, avoid it, please. Yes, I'll definitely do that.
> Since I've merged your plugin into master branch it would be wonderful if > you could continue work on it: > > 1) migrate it to new plugins API (feel free to ask me details). > 2) use lightweight FmXmlFile API instead of heavy libxml one. > 3) implement loading of info in another thread (you may use convenient > API fm_run_in_default_main_context() to deliver results into the main > thread). I keep on trying to get going on the fixes and now that the plugin made it to master, I better get my stuff together... I'll get working on Daniele's suggestions, first (mostly cleanup and minor functionality tweaks). Then, I'll migrate over to tighter integration with libfm and the new API. > Andriy. Thanks for all the hard work, Andriy, nice to see LXDE moving forward. Cheers! Piotr ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
