Hi On Mon, May 12, 2014 at 2:00 PM, PCMan <pcman...@gmail.com> wrote: > Hello, > I'm willing to work on liblxqt Qt5 port. > Sokoloff already did the most parts. > Julien just fixed the remaining stuff. > If there are no objections, I'd like to continue their work and finish > the Qt5 migration of liblxqt. > Here are some issues to be discussed. > > 1. Header names: > Sokoloff changed the header names in his Qt5 branch. > The proposed change is from #include <lxqt/lxqtsettings.h> to #include > <LxQt/Settings>. IMO this makes sense, keeping namespace LxQt while > making the name short and readable. > If there're no objections, I'd like to fix other components to use the > new header names.
If we're going to change this, can we move to LXQt instead of LxQt? Having the same capitalization everywhere would be nice. As a sidenote, is this related to qt5 at all? > > 2. Library names: > The Sokoloff Qt5 branch change the library name to liblxqt4 for Qt4 > and liblxqt5 for Qt5. > I think it's better to use liblxqt-qt4 and liblxqt-qt5 because some > distros append so-version to package name of libs. For example, > libqtxdg1. The number 1 is from lib version, not the version of Qt. In > the case of liblxqt5, this will result in something like liblxqt51, > which is very confusing. So, I propose changing it to liblxqt-qt(4|5) > instead. Agreed. > > 3. USE_QT5, or USE_QT=5? > I saw Luis did some work on the QtX CMake module. Should we use that > module for all LXQt components? Currently every components use its own > way to add Qt5 support. USE_QT5 is the most commonly used flag in qt4+5 compatible apps. > > Please, comments are wanted. Since liblxqt is the core lib of many > components, it's a blocker of Qt5 ports of others so this should be > solved ASAP. > > Thanks! J. Leclanche ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
