On Fri, May 16, 2014 at 2:08 AM, Julien Lavergne <julien.laver...@gmail.com> wrote: > 2014-05-15 19:29 GMT+02:00 Alexis López Zubieta <azubi...@estudiantes.uci.cu>: >> Hello everyone: >> Now I have some free time, have you done something about the issues that >> PCman point out? I woul like to know in order to get my hands on it. > > Maybe we are waiting more comments ? > Btw, I continued my experiments with some of the comments, I have now > libqtxdg & liblxqt dual building and using same headers for qt4 / qt5. > For now, it's seems to work (I only test it on lxqt-about and partly > on lxqt-session) : > https://github.com/gilir/lxqt-about-qt5 > https://github.com/gilir/liblxqt-qt5 > https://github.com/gilir/libqtxdg-qt5 > > Regards, > Julien Lavergne
Since there were not many comments or objections, I'd suggest that we continue with the following items. 1. Use new portable header name #include <LxQt/Settings> and update all lxqt components to use this. (Well, should we rename LxQt here to LXQt and also do this in C++ code for the LxQt namespace? 2. Since we don't have consensus, leave the library name liblxqt5 as it is. This won't affect other components since they all use the values provided by liblxqt cmake config files and did not hard-code library names. We can rename the library anytime if it's needed. 3. Add USE_QT5 flag to every components at the moment so we can continue the porting. If later we want to use a common FindQtX cmake module, we can change it then. Though this may waste some time and increase some cpoy & paste work, to not block the development here, I see this inevitable. Anyway we need to move forward. If there are no objections from other developers, I'd like to base on Julien's Qt5 work and start migrating other components next week. Then, we can work together on Alexis López Zubieta's lxqt-panel branch to adopt the new changes in liblxqt master. Once it works, merge it back to lxqt-panel main repo. Cheers! ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
