[Lxde-list] [PATCH 6/7] Prevent NULL derreference in plugin.c.

[Mario J. Rugiero]

From: Mario Rugiero <mrugi...@gmail.com>

---
 src/plugin.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/plugin.c b/src/plugin.c
index 5b2398b..76d1724 100644
--- a/src/plugin.c
+++ b/src/plugin.c
@@ -366,11 +366,14 @@ void lxpanel_plugin_show_config_dialog(GtkWidget* plugin)
 {
     const LXPanelPluginInit *init = PLUGIN_CLASS(plugin);
     LXPanel *panel = PLUGIN_PANEL(plugin);
-    GtkWidget *dlg = panel->priv->plugin_pref_dialog;
+    GtkWidget *dlg;
+
+    g_return_if_fail(panel != NULL);
+
+    dlg = panel->priv->plugin_pref_dialog;
 
     if (dlg && g_object_get_data(G_OBJECT(dlg), "generic-config-plugin") == 
plugin)
         return; /* configuration dialog is already shown for this widget */
-    g_return_if_fail(panel != NULL);
     dlg = init->config(panel, plugin);
     if (dlg)
         _panel_show_config_dialog(panel, plugin, dlg);
-- 
2.17.1



_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list