Thanks! El lun., 10 sept. 2018 a las 11:31, Andriy Grytsenko (<and...@rep.kiev.ua>) escribió: > > Hello! > > Mario J. Rugiero has written on Monday, 10 September, at 10:49: > >- if (strtol(setting->str, &end, 10)) end = end; > >+ strtol(setting->str, &end, 10); > > Actually this is not redudant because if strtol result is ignored then > warning is generated. Maybe a comment is due, then, so the next one doesn't send this same patch :) I'm personally fond of the following style: if (function_that_would_warn()) ; // DO NOTHING maybe explaining why we do nothing, for example: if (function_that_would_warn()) ; // DO NOTHING, silence an ignored return value warning Or even better, I think there's a pragma to silence a specific warning in a specific line. If you agree with either approach, I could send a patch later. > > Thank you for your contribution with other fixes, they look pretty fine. > > With best regards, > Andriy.
Regards, Mario. _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
