> > The fact is, though, I don't see the *problem* you do.
> 
> Try two of the documents I use to test it:
> 
> http://earthspace.net/The_sky/sky_top.html
> http://weather.ec.gc.ca/forecast/yul.html
> 
> Try with lynx/slang and lynx/ncurses and you'll see the difference.

Well, I must confess it will be impossible for me to test with ncurses,
but I did the next best thing and tested with MSIE (Oh! Hurts!).  _To
me_, anyway, there is no "problem."  In fact, having the underlining is
really the kind of emphasis the people who designed those pages are
hoping for, AFAIKT.

> > Without knowing how you access Lynx it's hard to say much,
> 
> I access it through a shell acces in my ISP. I use a VT100/VT102 terminal
> emulator with color support. I dial to my ISP and access the shell.

Well, you've been warned about that :).  Hope your description's name is
not "vt100", but some unique name.  I often use the model number of the
monitor, PC or modem, whatever is appropriate for the situation.

> > two routes depending on where you want to redefine them. Easiest might be
> > to change your terminfo description, i.e., change smul and rmul (I *think*
> > those are the ones.) to nullify them or change them to bold or something
> > rather than have underlining.
> 
> I dont want to follow that path. By doing that I would be just masking the
> problem. I want it to be corrected. It was by doing that that the problem was

I agree there.

> > The other way would be to patch Lynx to remove the underline attribute
> > associated with those colors. To be thorough you probably would have to
> > grep through the /src source files for things like "USE_SLANG,"
> > "UNDERLINE_," "start_underline," etc.
> 
> That's what I wanted to do. I did a grep on underline and tried to find out
> where the problem could be but my knowledge of C and of the lynx code didn't
> take me anywhere.

That's why no one else has done it.  It's not worth anyone's time unless
it's important or *fun* enough for him/her.

> > since as Klaus has pointed out, some (a lot?) of those if clauses with
> > USE_SLANG are probably no longer needed.
> 
> Do you remember when he mentioned that?

Around the time John Davis did major changes, 0.38???  Maybe 1997.

> > Klaus also questioned these lines in LYCurses.c:
> >    728          SLtt_add_color_attribute(4, SLTT_ULINE_MASK);
> >    729          SLtt_add_color_attribute(5, SLTT_ULINE_MASK);
> > Maybe you can just delete them; worth a try if underlining is so undesirable.
> 
> Et voil�!!! Thank you very much, Henry. Removing those two lines corrected
> the problem. I knew it would take a lot less time to correct the problem
> than to discuss if the problem is really a problem, if it's "hardcoded" or

Is it a "problem" still remains questionable.  

> I don't know whether that change will have side effects but it's working
> fine. Here's the patch, which I hope will be incorporated into the next
> release:

I can't agree with blind incorporation.  See below.

>  #if (defined(VMS) || defined(UNIX)) && !defined(__CYGWIN__)
> -     SLtt_add_color_attribute(4, SLTT_ULINE_MASK);
> -     SLtt_add_color_attribute(5, SLTT_ULINE_MASK);

Why is that "!defined(__CYGWIN__" there?  Indicates to me that the whole
if statement is wrong and shouldn't be there.  What does color_attribute
have to do with OS?  Isn't CYGWIN practically UNIX?

Good ol' cut-n-paste has orphaned some lines.  We need someone who
can use an eraser as well as a pencil.

> Thank you very much again and take care.

Thank Klaus.  (I should say more in the way of praise, but will refrain.)

__Henry

Reply via email to