On Wed, Apr 18, 2007 at 02:32:57PM +0200, Abdelrazak Younes wrote: > José Matos wrote: > > On Wednesday 18 April 2007 1:01:46 pm Enrico Forestieri wrote: > >>> For me real > >>> communication looks like this: > >>> > >>> 1) Developer X sends a patch and explains what it is doing > >>> 2) Developer Y finds a problem and possibly presents a solution > >>> 3) Developer X confirms that the solution still fixes the original > >>> problem, or presents one himself, or has still some questions. > >>> > >>> 2) and 3) could be repeated a few times, but in the end both X and Y > >>> understand the whole problem, and not only parts of it. > >>> > >>> I believe that this is the case now for the delimiters case, but what > >>> happens currently very often is "first commit, then think". This is what > >>> I call playing bug ping pong (you fix one bug by introducing another), > >>> especially since the commit messages are often too short and do not > >>> explain the changes, so it is very difficult for others to follow. > >> I totally agree with you here. > >> > >> -- > >> Enrico > > > > +1 > > +1000 > > I always think before commit :-)
Abdel, I think that you are missing the point here. Please reread what Georg said. Nobody is claiming that you don't think before committing, but I think that as a human being you can make an error or simply you don't take into account how your change may affect other parts of the code. Peer reviewing always helps improving the code and avoids hideous discussions afterwards. -- Enrico
