On Tue, May 22, 2007 at 11:35:28AM -0400, Richard Heck wrote: > José Matos wrote: > > On Tuesday 22 May 2007 6:24:41 am Richard Heck wrote: > > > >> A very simple patch to fix this bug. OK to commit? > >> > > OK. What do we loose with the removal of the regular expression? > > > Sorry, the patch is confusing. There were no regular expressions there. > The ones that appeared were commented out: My other idea for how to fix > this if the simple version didn't work.
Just a side note (not really related to this particular patch): Regexp compilation is notoriously slow, so whenever possible a regexp should be made a static const object and not created on the file. Andre'
