José Matos wrote:
On Sunday 15 July 2007 19:02:06 Dov Feldstern wrote:
I think I fixed the problem I was having, this patch now works. Please
try applying it and then converting as many files as you have lying
around from older version with it, just to make sure it doesn't break
anything. Jose --- could you also take a look at the code and see if
it's ok?

  Dov. I have thought a long bit about this patch.

It seems to me that are you saying that the translation from step 249 was incomplete.

If that is the case what you are trying to do is to finish that convertion so you don't need a new file format, we just need to add both the convertion and the retroversion to step 249 and there is no more any special case here.

  Am I wrong?


Umm, I was going to say that I think you are wrong, but on second thought, I think you're right. :)

What was bothering me is that there are documents lying around which have already been converted past 249, without the fix. But on second thought, the part that I put into LyX.py is exactly supposed to make sure that such documents *don't* get converted, because maybe they were only created after 249, in which case they aren't supposed to be converted at all! So what you're saying is that we actually don't need a new format, nor do we need the part I wanted to add in LyX.py --- those two things actually cancel each other out... So what we should do, is just add this new function to what happens in the conversion from 249, and everything will be the same... Yes, I believe you're right.

I'll test this and send in a revised patch.

Thanks!
Dov

Reply via email to