On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote:
> Andre Poenitz wrote:
> >The file TextClass_sptr.h seems to be missing from the patch?
> >
> Yes, sorry. Here it is.
Looks good in general.
I find the naming TextClass_sptr exceptionally ugle (CamelBump and
under_score mixed), but I know there are unfortunate precendents
(Layout_ptr). I guess I'd prefer TextClassPtr nevertheless.
> -void switchBetweenClasses(textclass_type c1, textclass_type c2,
> +void switchBetweenClasses(TextClass_sptr c1, TextClass_sptr c2,
> InsetText & in, ErrorList &);
Even if these are share pointers, why pass them as copy and not as
const&?
> +textclass_type BufferParams::getBaseClass() const
> +{
> + return baseClass;
> +}
Btw, Really simple stuff like that is allowed to go in the header
(inline in the class definition) That's not a requirement, though.
Andre'
