Andre Poenitz wrote:
On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote:
Andre Poenitz wrote:
Looks good in general.
Good.
I find the naming TextClass_sptr exceptionally ugle (CamelBump and
under_score mixed), but I know there are unfortunate precendents
(Layout_ptr). I guess I'd prefer TextClassPtr nevertheless.
I took it from the existing precedents. The ugly naming does at least
signal there's something unusual about the file.
-void switchBetweenClasses(textclass_type c1, textclass_type c2,
+void switchBetweenClasses(TextClass_sptr c1, TextClass_sptr c2,
InsetText & in, ErrorList &);
Even if these are share pointers, why pass them as copy and not as
const&?
I'll change that, thanks.
+textclass_type BufferParams::getBaseClass() const
+{
+ return baseClass;
+}
Btw, Really simple stuff like that is allowed to go in the header
(inline in the class definition) That's not a requirement, though.
I guess I prefer to keep the header uncluttered.
Richard
--
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
