On 04/12/2010 11:31 AM, Pavel Sanda wrote:
Vincent van Ravesteijn - TNW wrote:
- : action_(LFUN_NOACTION), origin_(o), x_(0), y_(0),
+ : argument_(0), action_(LFUN_NOACTION), origin_(o), x_(0),
y_(0),
What's the rationale about initializing a docstring with 0 ? (Does it
even compile ?)
hrmpf, i only wanted to add something for the place of argument_. now this
patch is buggy,
maybe even the next one i'm commiting right now... ;)
i want to have response from the reporter.
the whole thing is strange. since crash came from destructor and the only
thing really _changed_ in Richard's patch was the sequence of initialization -
my guess was it could be related because of missing argument.
I've tried restoring the initialization order. Otherwise, yes, it is
VERY strange. Note that this comes from LyX.cpp:531:
lyx::dispatch(FuncRequest(LFUN_WINDOW_NEW, geometryArg));
So the constructor was actually this one:
FuncRequest::FuncRequest(FuncCode act, string const & arg, Origin o)
: argument_(from_utf8(arg)), action_(act), origin_(o), x_(0),
y_(0),
button_(mouse_button::none)
{}
which initializes argument_ just fine.
Apparently, you guess didn't help, so I've reverted it. Now he can just
try the patch that changes back the initialization order. I've also
suggested he try a fresh checkout.
rh
