Am 05.09.2010 um 17:42 schrieb Uwe Stöhr:

> Am 05.09.2010 17:03, schrieb Vincent van Ravesteijn:
> 
>> Isn't it better to make a function GuiPainter::thinline or so, instead of 
>> everywhere specifying the
>> 0.5 ?
> 
> Currently there are only 3 places in the code (all in rowpainter.cpp) where 
> the former Painter::line_thin was used. Therefore I did not implement a new 
> function GuiPainter::thinline that outputs 0.5.

I think Vincent is right here, it isn't a good idea to place 0.5 here and there.

Anyway, I cannot build LyX anymore. The attached patch helps.
Did you forget to commit something?

Stephan

Index: src/insets/InsetLine.cpp
===================================================================
--- src/insets/InsetLine.cpp    (Revision 35284)
+++ src/insets/InsetLine.cpp    (Arbeitskopie)
@@ -59,8 +59,7 @@
 void InsetLine::draw(PainterInfo & pi, int x, int y) const
 {
        Dimension const dim = dimension(*pi.base.bv);
-       pi.pain.line(x, y, x + dim.wid, y, Color_foreground,
-               Painter::line_solid, Painter::line_medium);
+       pi.pain.line(x, y, x + dim.wid, y, Color_foreground);
 }
 
 

Reply via email to