Uwe Stöhr wrote: > Am 05.09.2010 17:03, schrieb Vincent van Ravesteijn: > >> Isn't it better to make a function GuiPainter::thinline or so, instead of >> everywhere specifying the >> 0.5 ? > > Currently there are only 3 places in the code (all in rowpainter.cpp) where > the former Painter::line_thin was used. Therefore I did not implement a new > function GuiPainter::thinline that outputs 0.5.
its generally bad idea to put magic numbers all around. now you know there are 3 places, later nobody will remember that these three numbers are "the same". i see just in next commit you add "1". who is going to understand the intention after year or two? pavel
