Am 02.11.2010 um 10:22 schrieb Vincent van Ravesteijn: > >> > >> After my last commit in readFile() it's "only" the issue with >> file_found_hook being called with the wrong file name in case of autosave >> and emergency. >> >> > >> I'd like to fix it before (2) or maybe Vincent does it... >> >> > >> For users of VCS I'd rate it as a serious problem - but not critical. >> > To illustrate my plan I post a patch - it's compiling and I tested it quickly. > I hope that's acceptable. Vincent? Do you have a better proposal? > > Stephan > > > > > /// emergency or autosave files, one should use \c loadLyXFile. > > /// /sa loadLyXFile > > ReadStatus loadThisLyXFile(support::FileName const & fn); > >+ ReadStatus loadThisLyXFile(support::FileName const & fn, > >support::FileName const & on); > > /// read a new document from a string > > bool readString(std::string const &); > > /// Reloads the LyX file > > > I don't like this. Adding another parameter to a public function, which you > wouldn't expect at all. Buffer only knows about autosave/emergency/backup > files. loadThisLyXFile was supposed not to do anything with > emergency/autosave files at all, so it is strange that it needs some extra > parameter. > > > Let me think how to solve it properly.
No problem. Thanks. Stephan
