Am Montag, 22. Juni 2015 um 16:53:06, schrieb Kornel Benko <kor...@lyx.org> > Am Montag, 22. Juni 2015 um 16:10:35, schrieb Jean-Marc Lasgouttes > <lasgout...@lyx.org> > > Le 19/06/2015 16:31, Kornel Benko a écrit : > > > From memory: > > > 1.) start lyx, the minibuffer is already displayed. > > > 2.) open any file > > > 3.) M-x, the cursor is displayed in the minibuffer > > > 4.) M-x, in the minibuffer appears 'x' > > > 5.) click on a view, cursor is displayed in both, minibuffer and buffer > > > 6.) enter 'abcd', it goes to minibuffer and not to buffer > > > > Try this one. It fixes this problem and: > > - do not close the minibuffer if the action gave an error; currently it > > relies on DispatchResult::error() > > - simplifies the code: get rid of the spacial "off" parameter to > > command-execute. > > - get rid of the hard-coded M-x to close the minibuffer. > > > > I understand that the behavior of the patch is still not optimal. > > Comments are welcome. > > > > JMarc > > > > This one definitely is better. > > Next glitch, sorry: > > Calling e.g. 'M-x dialog-show spellchecker<return>' > not only opens the dialog, but executes it, so that there is a dialog message > 'We are at end of document, do you want to proceed from the start' > Clocking on 'yes' or 'no' closes the minibuffer _and_ also the spellchecker > window. > > This behaviour is not OK, since our key-tests cannot work anymore. >
Wrong example. The file had no problems with spellchecking, the behaviour with
the dialog is the same as before.
The only difference is the now closed minibuffer.
Using e.g. 'dialog-show findreplaceadv', it behaves like expected.
Kornel
signature.asc
Description: This is a digitally signed message part.
