On Sun, Jan 03, 2016 at 04:20:05PM +0000, Guenter Milde wrote: > On 2016-01-03, Scott Kostyshak wrote: > > On Sun, Jan 03, 2016 at 09:02:40AM +0000, Guenter Milde wrote: > > ... > > >> >> The following patch will auto-select polyglossia with fontspec whenever > >> >> possible. > > >> >> OK to commit? > > >> > Are there any differences in the test results? I forget---you are able > >> > to run the tests right? At some point I remember you could not run them > >> > but I think we figured it out. > > >> There are differences. The augmented patch includes what I think will be > >> the > >> changes and the reasons. However, I did not run the tests. > > >> I can play with the test selection and labeling, but all tests return > >> failure (probably, because I compile LyX with autotools make in a > >> different build-dir). > > > Are you interested in running the tests? > > At some stage, I hope to be able to run selected tests without hampering my > cusomworkflow.
Please ask questions if you're not sure how to do this. > At the moment, I'd rather just want to know, whether it is OK to commit the > patch and my other patch (for \AA-consolidation). Fine with me. With regard to this patch I gave my opinion (sent just a few minutes ago). Let me know if you didn't receive it. With regard to the \AA patch hopefully someone else who understands it can give it a +1. > I wont be able to run all tests anyway. However, I promise to care about > eventually arising problems. Sounds good to me. Scott
signature.asc
Description: PGP signature
