Le 12/06/2016 à 06:46, Richard Heck a écrit :
commit 1bd5ef9a754a5b521f9d067b68fdac26035ef342
Author: Richard Heck <rgh...@lyx.org>
Date: Sat Jun 11 23:26:02 2016 -0400
Add some comments to fix coverity #23386.
diff --git a/src/frontends/qt4/GuiApplication.cpp
b/src/frontends/qt4/GuiApplication.cpp
index 460d7ad..022418f 100644
--- a/src/frontends/qt4/GuiApplication.cpp
+++ b/src/frontends/qt4/GuiApplication.cpp
@@ -1670,7 +1670,10 @@ void GuiApplication::dispatch(FuncRequest const & cmd,
DispatchResult & dr)
boost::crc_32_type crc;
crc = for_each(fname.begin(), fname.end(), crc);
createView(crc.checksum());
+ // we know current_view_ is non-null, because
createView sets it.
Could you explain where does createView set current_view_? I am lost in
this function. Normally coverity is able to follow these things.
JMarc
+ // coverity[FORWARD_NULL]
current_view_->openDocument(fname);
+ // FIXME but then why check current_view_ here?
if (current_view_ &&
!current_view_->documentBufferView())
current_view_->close();
} else {
