Re: cannot compile master

[Kornel Benko]

Am Freitag, 9. September 2016 um 22:29:23, schrieb Guenter Milde 
<mi...@users.sf.net>
> On 2016-09-09, Scott Kostyshak wrote:
> > On Fri, Sep 09, 2016 at 12:04:23PM +0000, Guenter Milde wrote:
> >> Dear LyX Developers,
>
> >> as of today, I cannot compile master, "make" fails with
> ...
> >> GuiView.cpp:(.text+0x1fa85): undefined reference to 
> >> `QSvgRenderer::~QSvgRenderer()'
> ...
>
> >> This is building with cmake from a repo updated today 2016-09-09.
>
> > I can reproduce with current master (b9a47dff) and Qt 4, but not Qt 5.
>
> I believe the reason is in 82808fea04315fd323ec074e8a
> "Set window title according to platform UI"
>
> #include <QStackedWidget>
>  #include <QStatusBar>
> -#if QT_VERSION >= 0x050000
>  #include <QSvgRenderer>
> -#endif
>  #include <QtConcurrentRun>
>  #include <QTime>
>
> and later use of the SVG renderer...
>
> Reverting that commit locally helped.
>
> Günter

Adding ${QT_QTSVG_LIBRARY} to target_link_libraries for lyx works here.

        Kornel

signature.asc
Description: This is a digitally signed message part.

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 0c56ce6..b7d1b06 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -132,6 +132,9 @@ target_link_libraries(${_lyx}
 	${LYX_QTMAIN_LIBRARY}
 	${vld_dll})
 
+if(LYX_USE_QT MATCHES "QT4")
+  target_link_libraries(${_lyx} ${QT_QTSVG_LIBRARY})
+endif()
 qt_use_modules(${_lyx} Core Gui)
 
 if(QT_USES_X11)