On 2 Mar 2001, Jean-Marc Lasgouttes wrote:
> Indeed I missed the patch... Now I read it and have a few remarks
> (again!):
>
> - why do we force a '-' before the suffix? Using
> --with-lyx-version=-blah is not more difficult that ...=blah
I thought it was more obvious, but I'm ambivalent, I can change it
if you want
> - I'd rather have the switch named --with-version-suffix, since it
> seems more self explaining to me
agreed
>
> - in LYX_VERSION_SUFFIX, the help text is not coherent (uses <version>
> and <suffix>)
>
ok
> - why is the stuff with ac_configure_args needed? It seems a bit scary
> to me, especially since it seems that --with-lyx-version=blah will
> be changed to --with-lyx-version=blah=blah.
This is needed to pass the correct modified version in the case where
none is specified to the reLyX configure.in (for the others it doesn't actually
matter). The reason it doesn't do what you say above is simple : this
case is only hit when no suffix is specified (i.e. $withval = yes)
I don't like it either but there is no real clean way to pass this info
down.
> Indeed. Do you want me to apply this patch as is, and fix it later?
I'm working on it now, then I'll do another for 1.2.0cvs
thanks
john
--
"I hear you have four hundred and eighty six PCs for sale ?"
- Some Fool
