On Wed, Oct 18, 2017 at 10:54:57AM +0200, Jean-Marc Lasgouttes wrote:
> Le 18/10/2017 à 10:29, Enrico Forestieri a écrit :
> > On Wed, Oct 18, 2017 at 10:18:42AM +0200, Jean-Marc Lasgouttes wrote:
> > > Le 18/10/2017 à 10:13, Enrico Forestieri a écrit :
> > > > > It should be rather safe:
> > > > > http://doc.qt.io/qt-4.8/qsettings.html#accessing-settings-from-multiple-threads-or-processes-simultaneously
> > > > 
> > > > This would be the attached patch. Now I don't experience any delay on 
> > > > quit.
> > > 
> > > Thanks for doing it Enrico. Just a question: why is it necessary to 
> > > #include
> > > <QSettings> instead of just forward-declaring the class?
> > 
> > The compiler doesn't like it:
> > 
> > ../../../../src/frontends/qt4/GuiToolbar.cpp:356:10: error: invalid use of 
> > incomplete type ‘class lyx::QSettings’
> 
> You have to declare it outside of the lyx:: namespace, like in the attached
> version.

Doh! Please, go ahead and commit your version.

-- 
Enrico

Reply via email to