On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:

Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many
other apps have fixed height find dialogs.

Ah I see. Thanks for the explanation. Seems reasonable to me.

Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs.

Daniel

Spellchecker dialog.

Thesaurus dialog.

Compare dialog.

Preferences dialog. (This might be a more controversial change.)

Messages Pane.

Search & Replace Advanced. A bit more extensive changes.

Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached.

Daniel
>From 9922b971ae8c8419a1e369e427b8981072b4c01e Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller <d....@web.de>
Date: Fri, 16 Nov 2018 15:28:59 +0100
Subject: [PATCH] Fix for Insert Table dialog: - Correct spacer position

---
 src/frontends/qt4/ui/TabularCreateUi.ui | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/src/frontends/qt4/ui/TabularCreateUi.ui 
b/src/frontends/qt4/ui/TabularCreateUi.ui
index 11dbf5bfe6..6a0ad76e50 100644
--- a/src/frontends/qt4/ui/TabularCreateUi.ui
+++ b/src/frontends/qt4/ui/TabularCreateUi.ui
@@ -83,23 +83,17 @@
          </property>
         </widget>
        </item>
+       <item>
+        <spacer name="horizontalSpacer">
+         <property name="orientation">
+          <enum>Qt::Horizontal</enum>
+         </property>
+        </spacer>
+       </item>
       </layout>
      </item>
     </layout>
    </item>
-   <item row="0" column="1">
-    <spacer name="horizontalSpacer">
-     <property name="orientation">
-      <enum>Qt::Horizontal</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>40</width>
-       <height>20</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
    <item row="1" column="0">
     <widget class="EmptyTable" name="table" native="true">
      <property name="sizePolicy">
-- 
2.17.0.windows.1

Reply via email to