Re: Patch test with several minor dialog alignment fixes

[Daniel]

On 22/11/2018 10:41, Daniel wrote:

On 22/11/2018 10:38, Daniel wrote:

On 16/11/2018 15:41, Daniel wrote:

On 31/10/2018 18:20, Daniel wrote:

On 31/10/2018 17:46, Daniel wrote:

On 31/10/2018 15:25, Daniel wrote:

On 31/10/2018 07:57, Daniel wrote:

On 31/10/2018 07:24, Daniel wrote:

On 30/10/2018 21:23, Daniel wrote:

On 30/10/2018 17:37, Daniel wrote:

On 30/10/2018 16:46, Scott Kostyshak wrote:

On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:

Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many

other apps have fixed height find dialogs.

Ah I see. Thanks for the explanation. Seems reasonable to me.

Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs.

Daniel

Spellchecker dialog.

Thesaurus dialog.

Compare dialog.

Preferences dialog. (This might be a more controversial change.)

Messages Pane.

Search & Replace Advanced. A bit more extensive changes.

Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached.

Daniel

I suggest a fixed minimum height for the Text Properties dialog.

Reasons:
- It cannot profit from greater height

- It might not have its minimum height initially and hence look awkwardly stretched

Daniel

And the patch ...

Paragraph dialog fixes attached.

Daniel

>From ce562ab9c66b7b3bd0c5087101fc5c19ea761e68 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller <d....@web.de>
Date: Thu, 22 Nov 2018 10:53:36 +0100
Subject: [PATCH] Paragraph dialog fixes: - Fixed minimum height - Non-flat
 groups boxes

---
 src/frontends/qt4/GuiParagraph.cpp  |  3 +++
 src/frontends/qt4/ui/ParagraphUi.ui | 15 ---------------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/frontends/qt4/GuiParagraph.cpp 
b/src/frontends/qt4/GuiParagraph.cpp
index b7e1050a3f..09690f7a9e 100644
--- a/src/frontends/qt4/GuiParagraph.cpp
+++ b/src/frontends/qt4/GuiParagraph.cpp
@@ -50,6 +50,9 @@ GuiParagraph::GuiParagraph(GuiView & lv)
 {
        setupUi(this);
 
+       // fix height to minimum
+       setFixedHeight(sizeHint().height());
+
        connect(alignDefaultRB, SIGNAL(clicked()), this, SLOT(changed()));
        connect(alignJustRB, SIGNAL(clicked()), this, SLOT(changed()));
        connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(changed()));
diff --git a/src/frontends/qt4/ui/ParagraphUi.ui 
b/src/frontends/qt4/ui/ParagraphUi.ui
index 64d7139b2f..09b6c1b96f 100644
--- a/src/frontends/qt4/ui/ParagraphUi.ui
+++ b/src/frontends/qt4/ui/ParagraphUi.ui
@@ -22,9 +22,6 @@
      <property name="title">
       <string>Line &amp;spacing</string>
      </property>
-     <property name="flat">
-      <bool>true</bool>
-     </property>
      <layout class="QGridLayout">
       <property name="leftMargin">
        <number>9</number>
@@ -85,9 +82,6 @@
      <property name="title">
       <string>Alignment</string>
      </property>
-     <property name="flat">
-      <bool>true</bool>
-     </property>
      <layout class="QGridLayout">
       <property name="leftMargin">
        <number>9</number>
@@ -153,9 +147,6 @@
      <property name="title">
       <string>Label Width</string>
      </property>
-     <property name="flat">
-      <bool>true</bool>
-     </property>
      <layout class="QGridLayout">
       <property name="leftMargin">
        <number>9</number>
@@ -207,12 +198,6 @@
      <property name="orientation">
       <enum>Qt::Vertical</enum>
      </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>351</width>
-       <height>16</height>
-      </size>
-     </property>
     </spacer>
    </item>
    <item row="4" column="0" rowspan="2" colspan="2">
-- 
2.17.0.windows.1