Am Freitag, den 08.03.2019, 22:16 +0530 schrieb Joe Doe: > Oh. Sorry. Thank you for the help.
You're welcome. One minor thing:
> revert = [
> + [567, [revert_malayalam]],
must be
[566, [revert_malayalam]],
since in revert, we refer to the version we revert to (the one before
the feature to revert was introduced)
Also, it looks like the indentation is wrong at this very place and the
convert list above (you used tabs, whereas spaces are used). Python is
picky with this.
Thanks
Jürgen
> Joice
>
>
> 08.03.2019, 21:35, "Jürgen Spitzmüller" <sp...@lyx.org>:
> > Am Freitag, den 08.03.2019, 21:17 +0530 schrieb Joe Doe:
> > >
> > > 08.03.2019, 21:10, "Joe Doe" <joi...@yandex.com>:
> > > > I will update and send the patch now within,
> >
> > I think you misunderstood. You should not change lyx_2_3.py at all.
> > Instead, move your new reversion routines to lyx_2_4.py.
> >
> > Jürgen
> >
> > > > ~ Joice
> > > >
> > > >
> > > > 08.03.2019, 20:09, "Jürgen Spitzmüller" <sp...@lyx.org>:
> > > > > Am Donnerstag, den 21.02.2019, 10:12 +0530 schrieb Joe Doe:
> > > > > > I made some changes. I don't know the changes I made to
> > > > > > lib/lyx2lyx/lyx_2_3.py is correct. Please help me to
> > > complete
> > > > > > the
> > > > > > changes please.
> > > > > > Please find the patches.
> > > > >
> > > > > The lyx2lyx stuff must go to lyx_2_4.py (rather than
> > > lyx_2_3.py).
> > > > >
> > > > > Other than that, the patch looks good to me.
> > > > >
> > > > > Thanks,
> > > > > Jürgen
> > > > >
> > > > > > ~ Joice
> > > > > >
> > > > > >
> > > > > > 21.02.2019, 07:38, "Richard Kimberly Heck" <
> > > rikih...@lyx.org>:
> > > > > > > On 2/20/19 12:43 PM, Jean-Marc Lasgouttes wrote:
> > > > > > > > Le 20/02/2019 à 16:23, Pavel Sanda a écrit :
> > > > > > > > > On Wed, Feb 20, 2019 at 09:04:59AM +0000, Joice
> > > Joseph
> > > > > > wrote:
> > > > > > > > > > Hi, last day. I had send a patch file which
> > > introduced
> > > > > > > > > > language support
> > > > > > > > > > for Malayalam - an Indic language like Tamil and
> > > > > > Telugu. I
> > > > > > > > > > didn't
> > > > > > > > > > placed
> > > > > > > > > > the definition in the correct (alphabetic order)
> > > > > > place. So I
> > > > > > > > > > had
> > > > > > > > > > changed
> > > > > > > > > > the patch placing it correctly. babel have support
> > > for
> > > > > > > > > > Malayalam now.
> > > > > > > > > > So, I have included that as well.
> > > > > > > > > >
> > > > > > > > > > Please merge with the main code base and make it
> > > > > > available
> > > > > > > > > > for everyone
> > > > > > > > > > please.
> > > > > > > > > >
> > > > > > > > > > Please find the attached patch with this email.
> > > > > > > > >
> > > > > > > > > Hello and welcome here!
> > > > > > > > >
> > > > > > > > > I am afraid this patch is not enough, see e.g. this
> > > > > > commit
> > > > > > > > > which
> > > > > > > > > introduces different
> > > > > > > > > langauge support:
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > https://www.lyx.org/trac/changeset/d9c52c7a3f06ec892cd2e36d0d20998bc99b2fd8/lyxgit
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Uwe is not much around these days, but maybe someone
> > > > > > else
> > > > > > > > > could give
> > > > > > > > > you a helping hand
> > > > > > > > > if the hint above is too difficult...
> > > > > > > >
> > > > > > > > I am not a specialist either but the changes boil down
> > > to
> > > > > > three
> > > > > > > > parts:
> > > > > > > >
> > > > > > > > 1/ Introduce a new LyX document version (because older
> > > > > > versions
> > > > > > > > of LyX
> > > > > > > > will not be able to read a document in malayalam. We
> > > > > > increase
> > > > > > > > version
> > > > > > > > number at each change.
> > > > > > > >
> > > > > > > > Note that this means that the new language will only
> > > be
> > > > > > > > available with
> > > > > > > > LyX 2.4.0. This is annoying, but we do not add new
> > > > > > language sto
> > > > > > > > stable
> > > > > > > > releases.
> > > > > > > >
> > > > > > > > Concerns: src/version.h
> > > > > > > >
> > > > > > > > 2/ update the mechanism that converts old documents to
> > > new
> > > > > > > > format
> > > > > > > > (trivial, nothing to do) and to revert documents using
> > > > > > malayalam
> > > > > > > > to
> > > > > > > > older format. This is the ugly part in the commit
> > > shown by
> > > > > > > > Pavel, and
> > > > > > > > unfortunately I do not know how to do it
> > > > > > > >
> > > > > > > > Concerns: stuff in lib/lyx2lyx
> > > > > > >
> > > > > > > I can probably find time to do these parts on Thursday.
> > > > > > >
> > > > > > >
> > > > > > > > 3/ implement LaTeX importation. In proactice, one just
> > > has
> > > > > > to
> > > > > > > > add the
> > > > > > > > language names to some array. This shouid probably use
> > > the
> > > > > > > > lib/language file, but it is not done currently.
> > > > > > >
> > > > > > > I can also figure that part out, but for now it could be
> > > > > > left as
> > > > > > > TODO.
> > > > > > >
> > > > > > > Riki
> > > > > > >
> > > > > > >
signature.asc
Description: This is a digitally signed message part
