On Tue, 11 Jun 2002, John Levon wrote: > I'm going to try new "executive summaries" in the hope that this makes > the purpose AND the rationale of each patch clearer. > > o removes useless methods belowMouse() and active() from workarea > o hides access to the work area behind workarea()
Good stuff. > o makes workarea a scoped_ptr rather than a child Personally, I think this is just fine. > 3. no core code is polluted with toolkit headers I see you added an X11-include into the pimpl.h file. Why is that needed? -- Technically, I'm too far away from the code before it would be fair for me to judge your patch as accepted or not. But I'm going to do that anyway. This is so, because I know you are the one that is the furthest ahead in the next step of the GUII work. Therefore I think it is fair that we trust your judgement. Especially in this situation where we can foresee an obvious merging-hell in the immediate future. So I'd say, depending on your courage, either commit this stuff right now, or at least continue work assuming that it will be accepted more or less as is when someone has time to look at it more closely. I promise you that if the others disagree strongly with me, I will have to defend you against them. Hey, I can do that: The thing is that issues such as these are non-issues at a meeting. We just discuss the matter for five minutes, and then hack it up. In the worst scenario, I have to spend the time to revert any controversial bits. So, please go ahead and see how much of the "safe" stuff you can merge. I believe time is against us, so breaking the rules a bit is in everybody's interest right now. They call it civile courage in Denmark. Greets, Asger
