On Tue, Jun 11, 2002 at 10:41:16PM +0200, Asger K. Alstrup Nielsen wrote:
> > 3. no core code is polluted with toolkit headers
>
> I see you added an X11-include into the pimpl.h file.
> Why is that needed?
For KeySym. It's a temporary step (my tree uses a struct instead).
> So I'd say, depending on your courage, either commit this stuff
> right now, or at least continue work assuming that it will be
> accepted more or less as is when someone has time to look at it
> more closely.
I'm cooking up a couple more patches now ...
... but I won't commit with some rough consensus. I'd rather live with a
merging nightmare than introduce a real bogosity.
On the other hand, it must be remembered that iterative development
is the only sensible way to go about this stuff: a 90% solution is still
better than a 0.0 * 100% solution, if you see what I mean :)
> will have to defend you against them. Hey, I can do that: The
> thing is that issues such as these are non-issues at a meeting.
> We just discuss the matter for five minutes, and then hack it
> up.
Perhaps you could start with a review of my patch queue, then work from
there ?
regards
john
--
"I continue to be amazed at what Andrei can make templates do. Some of it
still makes my head hurt."
- Herb Sutter
