Angus Leeming wrote:
>
> Incidentally, you can make dialogs smaller if you alter the code.
> Try, in FormBase.C/FormBaseDeprecated.C, setting minw_, minh_
> to 0.9 * form()->w, h. There should be some limit because it's
> possible to crash xforms otherwise.
I may give this a go, but later.
>>You mean: remove the "false" in the FormAboutlyx.C, and repair
>>the resize/gravity for the browsers?
>
> Yes. Or at least have a go. I couldn't get the browsers to resize,
> which may be an xforms bug or may be my incompetance.
I don't see any difference with the behaviour some time ago:
removing "false" could resize the main dialog, but not the tab items
inside the dialog. My guess: Xforms bug. So better leave the "false"
in place until it's fixed.
--------------------------------
I have a few polishing issues to Xforms files you applied earlier
today. Patch attached. ChangeLog:
2001-09-08 Rob Lahaye <[EMAIL PROTECTED]>
* FeedbackController.C: separate width as an "int const";
use proper default label color (FL_LCOL, instead of FL_BLACK).
* FormBibtex.C: remove two redundant header files.
* xforms_helpers.h: add "bool isActive(FL_OBJECT * ob);", which is
already defined in xforms_helpers.C.
--------------------------------
Index: src/frontends/xforms/FeedbackController.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/FeedbackController.C,v
retrieving revision 1.17
diff -u -r1.17 FeedbackController.C
--- src/frontends/xforms/FeedbackController.C 2002/10/23 08:31:10 1.17
+++ src/frontends/xforms/FeedbackController.C 2002/10/23 11:17:57
@@ -140,10 +140,11 @@
else
str = message;
- str = formatted(str, message_widget_->w - 10, FL_NORMAL_SIZE);
-
+ int const width = message_widget_->w - 10;
+ str = formatted(str, width, FL_NORMAL_SIZE);
fl_set_object_label(message_widget_, str.c_str());
- FL_COLOR const label_color = warning_posted_ ? FL_RED : FL_BLACK;
+
+ FL_COLOR const label_color = warning_posted_ ? FL_RED : FL_LCOL;
fl_set_object_lcol(message_widget_, label_color);
if (!message_widget_->visible)
Index: src/frontends/xforms/FormBibtex.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/FormBibtex.C,v
retrieving revision 1.43
diff -u -r1.43 FormBibtex.C
--- src/frontends/xforms/FormBibtex.C 2002/10/23 10:08:55 1.43
+++ src/frontends/xforms/FormBibtex.C 2002/10/23 11:17:58
@@ -26,8 +26,6 @@
#include "helper_funcs.h"
#include "gettext.h"
-#include "debug.h"
-#include "support/LAssert.h"
#include "support/lstrings.h"
#include "support/filetools.h"
#include "support/lyxalgo.h"
Index: src/frontends/xforms/xforms_helpers.h
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/xforms_helpers.h,v
retrieving revision 1.31
diff -u -r1.31 xforms_helpers.h
--- src/frontends/xforms/xforms_helpers.h 2002/10/23 08:31:10 1.31
+++ src/frontends/xforms/xforms_helpers.h 2002/10/23 11:18:03
@@ -86,6 +86,10 @@
void setCursorColor(int color);
+/// return the (in)active state of the object
+bool isActive(FL_OBJECT * ob);
+
+
/// struct holding xform-specific colors
struct XformsColor : public NamedColor {
int colorID;
