>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> browseRelFile is defined in
Angus> frontends/controllers/helper_funcs.C. Maybe you could dig some
Angus> more?

OK, the `problem' is that several places call
QFileDialog::getOpenFileName explicitly:

schuss: grep -ri QFileDialog::get  1.3.x/
1.3.x/src/frontends/qt2/QBibtexDialog.C:                
QFileDialog::getOpenFileName(QString::null,
1.3.x/src/frontends/qt2/QBibtexDialog.C:        QString const file = 
QFileDialog::getOpenFileName(QString::null,
1.3.x/src/frontends/qt2/QExternalDialog.C:              
QFileDialog::getOpenFileName(QString::null,
1.3.x/src/frontends/qt2/QLPrintDialog.C:                
QFileDialog::getOpenFileName(QString::null,

schuss: grep -ri QFileDialog::get  lyx-devel/
lyx-devel/src/frontends/qt2/QBibtexDialog.C:            
QFileDialog::getOpenFileName(QString::null,
lyx-devel/src/frontends/qt2/QBibtexDialog.C:    QString const file = 
QFileDialog::getOpenFileName(QString::null,
lyx-devel/src/frontends/qt2/QLPrintDialog.C:            
QFileDialog::getOpenFileName(QString::null,

As you can see, the status of QExternalDialog has changed in 1.4.0cvs.
And this imo a bug that it does not use broweRelFile anymore (since
what we want is really a relative path.

However, it would be better to have browse*File use the native file
dialogs when possible. As far as I understand, the reason why we build
our own dialog is to be able to use the extra buttons to set special
directories, like "Documents" and friends. 

So the question boils down to: does the benefit of these buttons
overweights the benefit of native dialogs?

A solution may be to always use native dialogs on windows and osx, and
use the existing code for Qt/X11.

Thoughts?

JMarc

Reply via email to