Jean-Marc Lasgouttes wrote:
> OK, the `problem' is that several places call
> QFileDialog::getOpenFileName explicitly:
>
> As you can see, the status of QExternalDialog has changed in
> 1.4.0cvs. And this imo a bug that it does not use broweRelFile
> anymore (since what we want is really a relative path.
Agreed. (Well done! A piece of good detective work.)
> However, it would be better to have browse*File use the native file
> dialogs when possible.
Agreed.
if (extra_buttons.empty())
call getOpenFileName
else
roll our own
?
> As far as I understand, the reason why we build our own
> dialog is to be able to use the extra buttons to set
> special directories, like "Documents" and friends.
>
> So the question boils down to: does the benefit of these buttons
> overweights the benefit of native dialogs?
Definitely.
Maybe out hand-rolled model should be re-worked so that it looks
similar to the native version? Ok forget that ;-)
> A solution may be to always use native dialogs on windows and osx,
> and use the existing code for Qt/X11.
A reduction in function for the sake of form? Is this a comment on
the philosophy underlying these OSes?
> Thoughts?
> JMarc
--
Angus
