Lars Gullik Bj�nnes wrote:

> At least I find it a bit nicer. Comments/Objections?

You go on to use 'MAX_CLIENTS' below, so don't cull it here:

Index: lyxsocket.C
-          fd_(lyx::support::socktools::listen(addr, MAX_CLIENTS)),
+          fd_(lyx::support::socktools::listen(addr, 3)),

In English it's "caught":
+                        // The program will also receive a SIGPIPE
+                        // that must be catched

> 
> I have not fixed up qt and gtk to use the same scheme yet.

Well, I see you got round to it in the next mail.

Incidentally, will this abstraction work on Windows machines which don't
use file descriptors?

Index: frontends/lyx_gui.h
+void register_socket_callback(int fd, boost::function<void()> func);
+void unregister_socket_callback(int fd);

Ie, does Qt provide an 'fd' identifier in its generic interface or is Joao
using some X11-specific Qt wrapper?

> (And I you wonder what I am doing: I am combing my way through the
> code and looking close at stuff that went in when I was not paying
> close attention. And trying to understand all the cryptic stuff that
> Andre added of course.)

Of course. It's good to see.

-- 
Angus

Reply via email to