Georg Baum <[EMAIL PROTECTED]> writes:

| Lars Gullik Bj�nnes wrote:
>
>> Please have a look at this and tell if you have problems with it.
>
>> @@�-522,8�+575,8�@@�FuncStatus�LyXFunc::getStatus(FuncReques
>> �
>> ���������default:
>> �
>> -����������������if�(!cur.getStatus(cmd,�flag))
>> -������������������������flag�|=�view()->getStatus(cmd);
>> +����������������if�(!::getStatus(cur,�cmd,�flag))
>> +������������������������flag�=�view()->getStatus(cmd);
>> ���������}
>
| Why "=" and not "|="? This may swallow a status message that may be stored
| in flag. The const stuff is of course fine.

if ::getStatus returns false, flag has not been set and thus we want
view()->getStatus instead.

AFAIK the code is good as it is now.

-- 
        Lgb

Reply via email to