>>>>> "Lars" == Lars Gullik Bj�nnes <[EMAIL PROTECTED]> writes:
Lars> Georg Baum <[EMAIL PROTECTED]> writes: Lars> | Lars Gullik Bj�nnes wrote: >> >>> Please have a look at this and tell if you have problems with it. >> >>> @@�-522,8�+575,8�@@�FuncStatus�LyXFunc::getStatus(FuncReques � >>> ���������default: � >>> -����������������if�(!cur.getStatus(cmd,�flag)) >>> -������������������������flag�|=�view()->getStatus(cmd); >>> +����������������if�(!::getStatus(cur,�cmd,�flag)) >>> +������������������������flag�=�view()->getStatus(cmd); ���������} >> Lars> | Why "=" and not "|="? This may swallow a status message that Lars> may be stored | in flag. The const stuff is of course fine. Lars> if ::getStatus returns false, flag has not been set and thus we Lars> want view()->getStatus instead. Georg, I think that Lars' patch is good after the changes that we have done to getStatus. OTOH it might be a good idea to change the signature of BufferView::getStatus from FuncStatus BufferView::getStatus(FuncRequest const & cmd) to bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag) JMarc
