-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
I've taken a quick look at your driver and have some comments / suggestions: 1) You use fps as an module variable. That doesn't seem particulary efficient to me. Why would you want to toggle the framerate at all? Don't you always want the fastest framerate? 2) Why do you have big fields of constants in the driver? Regards, Erik -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkj6LoQACgkQN7qBt+4UG0GoYwCaA1N5DWerEy63P2A2H3v4vkUm /KwAn2hqFQiXh2dRefrX9dqhGvUo28pw =VrxC -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ M560x-driver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
