-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Franck Bourdonnec wrote: > Le Saturday 18 October 2008 20:44:24, vous avez écrit : >> Hi, >> >> I've taken a quick look at your driver and have some comments / >> suggestions: >> >> 1) You use fps as an module variable. That doesn't seem particulary >> efficient to me. Why would you want to toggle the framerate at all? >> Don't you always want the fastest framerate? >> >> 2) Why do you have big fields of constants in the driver? >> >> Regards, >> Erik > > >>> fps: Don't you always want the fastest framerate? > yes I want the max for all ;-) I have not investiguated > yet the exact action off changing it except selecting > the best cloking with what you call big fields constants ;-) > > Probably this can be simplified again. Remember, all > is inspired from the windows driver! Yes, but the windows driver clearly doesn't always do things the "right" way. In the m5602 case, the .csr files containing some firmware was a red herring, they weren't actually used at all. > probably, I will move them out in a binary file, > like the firmware. Just to save some memory. > I don't know how large the firmware is but if it's of the same order as the m5602 it's probably easier to contain it in the driver like I did. > Ilies think having RGG565/555 is important. No > problem for the OV7648, but the Ali5603 don't understand > anything. Will try it again. For the jPeg, it seems less > hard to do. > If the chip supports multiple formats, you should of course try to support as many as possible with the optimal format preselected. Regards, Erik > Franck > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkj6S44ACgkQN7qBt+4UG0E+NQCfem0MNc1pclB2EcNCIj7r0vsF G/sAn1iVXLcCAdipTOBOM454/HVbj/LH =QC7x -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ M560x-driver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
