Comments inline. On Nov 30, 2007 5:25 AM, znek <[EMAIL PROTECTED]> wrote: > > Hi Ted, > > now it's me who's delaying... sorry about that.
No problem :-) > > > On Nov 26, 7:53 pm, "ted bonkenburg" <[EMAIL PROTECTED]> wrote: > > - (NSArray *)fuseArguments; // Additional arguments to pass to fuse. > > while this is more flexible, I still favor my approach. It took me > quite a while to figure out that "-olocal" shouldn't have a space > between the "o" and "local". My approach abstracts from the > commandline flag syntax and follows the original pattern which I quite > like. That's a good point about "-olocal" vs. "-o local". I had forgotten about that. On the command line either will work since standard getopt is used. FUSEFileSystem constructs its own argv directly, so that messes up getopt. Usually "-o local" looks like "-o" and "local" args to getopt; with FUSEFileSystem it looks like a single "-o local" argument. > > However, if there was another method called > > - (NSArray *)additionalFuseArguments; > > I'd say that's ok to have that as a future-proof extension. After seeing your "-o local" comment I realized that all we really need is: - (NSArray *)fuseOptions; I discussed this with Amit and aside from "-f" and "-s", everything else can and should be expressed as an option. They should all be documented in the wiki: http://code.google.com/p/macfuse/wiki/OPTIONS The approach I plan on going with is to have isForeground() and isMultiThreaded() handle "-f" and "-s" and for all entries in the array returned from fuseOptions add a "-oreturnedoption". I know this isn't exactly what you want, but I think it provides the best tradeoff between ease-of-use, future-proofing, and limiting the increase in the number of methods that people have to understand in order to use FUSEFileSystem. Please let me know if you strongly disagree. Otherwise I'll try to commit these changes soon. ted > > > any new options in the future. Given the rate at which options are > > added to MacFUSE and the time between commits to FUSEFileSystem, I > > suspect this would be a safer plan. > > Yes, but I'll rather see that as an additional option, not an > alternative. > > > Since the "-s" argument is currently present by default, I will be > > making that conditional on an isThreadSafe method returning YES, but > > in general I'd like to avoid adding more like this. > > See above, I think it's the much better API instead. > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "macfuse-devel" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/macfuse-devel?hl=en -~----------~----~----~----~------~----~------~--~---
