On 16/07/17 06:29, fairbanks-john wrote:
I went ahead and changed the machinekit script file "check-system-configuration.sh"  line 24 to machinekit.log instead of linuxcnc.log to work around the logging ok verification issue that shows with at the end of a current make process on my computer.

The /machinekit/src/rtapi/rsyslogd-machinekit.conf file does need to be copied to /etc/rsyslog.d/ if it is not there and then the logging service needs to be restarted with sudo service rsyslog restart.

Sorry, that is just wrong

/var/log/linuxcnc.log is hard coded into various files as the log path
eg
halcmd_commands.c and halcmd.c

If you change the name of the file, half the output will not reach the log

The output from check-system-configuration.sh is designed, so that the first time machinekit is run on a system, you can just cut and paste the commands in a terminal
to create the required files in the right places.

I don't know why there is a duplicate file in src/rtapi/ called rsyslog-machinekit.conf
If you do a grep you will find that is the only file which refers to machinekit.log, nothing else in the whole repo refers to it and certainly nothing logs to it.

Not all references to linuxcnc has been purged from machinekit,  some crucial libraries and binaries still have the linuxcnc name in them.

I will probably remove that file to prevent the confusion it has just caused.


On Saturday, July 15, 2017 at 9:52:48 AM UTC-8, fairbanks-john wrote:

I have been setting up linuxcnc and machinekit as a rip install on linuxmint 18.1. When running sudo make setuid  on the final part of the machinekit install I there is an error due to no log test entry being detected. This appears to be an error in the script file for the sudo make setuid  process. It is trying to read file /var/log/linuxcnc.log which I believe is not the correct file to use. Machinekit souce was cloned on 07/15/2017


In machinekit file location /machinekit/src/rtapi/ there are two logging configuration files, rsyslogd-linuxcnc.conf and rsyslogd-machinekit.conf.

I suspect that machinekit should be using the /machinekit/src/rtapi/rsyslogd-machinekit.conf file and then look at the generated /var/log/machinekit.log file instead of the linuxcnc.log that it reports to have found with zero entries having been made into that file by the machinekit logging verify test in the script for sudo make setuid.


I ended up copying the /machinekit/src/rtapi/rsyslogd-machinekit.conf  to /etc/rsyslog.d/ and then restarted the logging service with sudo service rsyslog restart,  and found that the logging to file /var/log/machinekit.log file that was generated automatically was being logged too just fine.


Should the sudo make setuid process not be looking for the logging test and verify in /var/log/machinekit.log instead of /var/log/linuxcnc.log or the rsyslogd-linuxcnc.log that is not likely even there?

--
website: http://www.machinekit.io blog: http://blog.machinekit.io github: https://github.com/machinekit
---
You received this message because you are subscribed to the Google Groups "Machinekit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
Visit this group at https://groups.google.com/group/machinekit.
For more options, visit https://groups.google.com/d/optout.

--
website: http://www.machinekit.io blog: http://blog.machinekit.io github: https://github.com/machinekit
---
You received this message because you are subscribed to the Google Groups "Machinekit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
Visit this group at https://groups.google.com/group/machinekit.
For more options, visit https://groups.google.com/d/optout.

Reply via email to