On 2007-03-17 13:00:50 -0700, [EMAIL PROTECTED] wrote:
> Revision: 22884
> http://trac.macosforge.org/projects/macports/changeset/22884
> Author: [EMAIL PROTECTED]
> Date: 2007-03-17 13:00:49 -0700 (Sat, 17 Mar 2007)
>
> Log Message:
> -----------
> * cleanup
>
> Modified Paths:
> --------------
> trunk/dports/editors/emacs-devel/Portfile
>
> Modified: trunk/dports/editors/emacs-devel/Portfile
> ===================================================================
> --- trunk/dports/editors/emacs-devel/Portfile 2007-03-17 19:45:51 UTC (rev
> 22883)
> +++ trunk/dports/editors/emacs-devel/Portfile 2007-03-17 20:00:49 UTC (rev
> 22884)
[...]
> +configure.args --mandir=${prefix}/share/man \
> + --infodir=${prefix}/share/info \
> + --without-x
> +configure.env LDFLAGS="-L${prefix}/lib" \
> + CFLAGS="-I${prefix}/include" \
> + CPPFLAGS="-I${prefix}/include"
Shouldn't -I${prefix}/include be only in CPPFLAGS?
IMHO, it is better to avoid setting CFLAGS, as this may disable
optimizations nad/or debug information (not checked).
> variant atsui requires carbon {
> - configure.env-delete CFLAGS="-I${prefix}/include"
> - configure.env-append CFLAGS="-I${prefix}/include -DUSE_ATSUI"
> + configure.env-append CFLAGS="\$CFLAGS -DUSE_ATSUI"
> }
Ditto, -DUSE_ATSUI should probably be in CPPFLAGS.
--
Vincent Lefèvre <[EMAIL PROTECTED]> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev
