On Mar 19, 2007, at 4:39 PM, Vincent Lefevre wrote:
On 2007-03-17 13:00:50 -0700, [EMAIL PROTECTED] wrote:
Revision: 22884
http://trac.macosforge.org/projects/macports/changeset/
22884
Author: [EMAIL PROTECTED]
Date: 2007-03-17 13:00:49 -0700 (Sat, 17 Mar 2007)
Log Message:
-----------
* cleanup
Modified Paths:
--------------
trunk/dports/editors/emacs-devel/Portfile
Modified: trunk/dports/editors/emacs-devel/Portfile
===================================================================
--- trunk/dports/editors/emacs-devel/Portfile 2007-03-17 19:45:51
UTC (rev 22883)
+++ trunk/dports/editors/emacs-devel/Portfile 2007-03-17 20:00:49
UTC (rev 22884)
[...]
+configure.args --mandir=${prefix}/share/man \
+ --infodir=${prefix}/share/info \
+ --without-x
+configure.env LDFLAGS="-L${prefix}/lib" \
+ CFLAGS="-I${prefix}/include" \
+ CPPFLAGS="-I${prefix}/include"
Shouldn't -I${prefix}/include be only in CPPFLAGS?
Although that *should* be true that's not always sufficient.
IMHO, it is better to avoid setting CFLAGS, as this may disable
optimizations nad/or debug information (not checked).
i believe the cflags set by the user are appended, aren't they? not
sure either.
anyway, as the log message says that commit was pure cleanup, 95%
whitespace, as can be seen here:
-configure.args --mandir=${prefix}/share/man --infodir=${prefix}/
share/info --without-x
-configure.env \
- LDFLAGS="-L${prefix}/lib" \
- CFLAGS="-I${prefix}/include" \
- CPPFLAGS="-I${prefix}/include"
[...]
+configure.args --mandir=${prefix}/share/man \
+ --infodir=${prefix}/share/info \
+ --without-x
+configure.env LDFLAGS="-L${prefix}/lib" \
+ CFLAGS="-I${prefix}/include" \
+ CPPFLAGS="-I${prefix}/include"
so i left those flags the way they were. if setting the cflags should
proof obsolete in this case, feel free to remove them of course.
Ditto, -DUSE_ATSUI should probably be in CPPFLAGS.
same goes here.
Regards,
Elias
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev
