-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mar 7, 2009, at 5:50 PM, [email protected] wrote:

On Mar 7, 2009, at 4:11 AM, Ryan Schmidt wrote:

On Mar 6, 2009, at 15:49, [email protected] wrote:

Revision: 47804
        http://trac.macports.org/changeset/47804
Author:   [email protected]
Date:     2009-03-06 13:49:15 -0800 (Fri, 06 Mar 2009)
Log Message:
-----------
cmake 2.6.3

[snip]

Did the maintainer approve this update, or was there a ticket filed to which the maintainer did not respond within 72 hours?
I was about to say this change was fine by me, but then realized: I'm not the maintainer!
Ha.
*ahem*
I'll go back to my room now.

Neither. I've been checking some other build issues with CMake, but I would prefer that we follow the procedure of creating tickets, assigning them to maintainers, and referencing them in commit messages.

Could we enable the Trac pre-commit-hook[1] that requires commit messages to reference open tickets? There have been a number of recent commits to ports without references to tickets, and that makes it hard to dig through Trac to find the background info for a particular commit. That's annoying for ports I maintain, especially without either any contact with me or tickets filed in Trac. (There have been some timeouts too, but that's part of the process. :)

I think we should require port commits to reference existing, open Trac tickets.

Chris

[1]: http://trac.edgewall.org/browser/trunk/contrib/trac-pre-commit-hook

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iEYEARECAAYFAkmzGo0ACgkQ2yWVgjgEOKQcnQCglCsRXnet66Vi0y/WKD61jCZ3
0lQAoKUeJ6/3ss00gN5tcR3VtbGgjvFn
=lV5j
-----END PGP SIGNATURE-----
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to