On Mar 12, 2009, at 13:58, Uwe Schwartz wrote:
Jeremy Lavergne wrote:
I changed the Portfile according to your suggestions.
The patch is submitted in ticket 18809:
http://trac.macports.org/ticket/18809
The revision on this one should NOT be updated, right?
Well, I am not sure. There are changes in the Portfile so I
increased
the revision to 1. But for users it's not really necessary to
update.
The rule of thumb that I've heard is that if it doesn't modify the
files
being generated then it ought not be increased.
Okay, there are no file changes. So revision change is not necessary.
I already committed it with the revision bump before reading these
messages.
There are valid reasons for increasing the revision even if the files
installed do not change, for example if the dependencies change, or
if the default variants change. The latter is why I didn't remove the
revision increase, though in this case I don't particularly care one
way or the other.
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
