On Aug 20, 2009, at 08:41, [email protected] wrote:
Revision: 55865
http://trac.macports.org/changeset/55865
Author: [email protected]
Date: 2009-08-20 06:41:53 -0700 (Thu, 20 Aug 2009)
Log Message:
-----------
KDE3: Force use of autoconf 2.63 instead of 2.64. (#20513)
Thanks! I was dreading going through all the kde3 ports and you've
saved me the trouble. :)
But it would have been better if you had not also made lots of other
unrelated changes in the same commit. In addition to the described
switch to autoconf 2.63, you changed categories, distfile tags, and
foreach variables, and removed overriding of the destroot and build
phases. While these are good changes to make, each of them should be
made in a separate commit, with a commit message that says what was
done. If you must combine changes into a single commit, at least
describe everything that's changed in the commit message; the message
for r55865 gives no indication that these other changes took place.
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
