Hi Ryan,

Thank you for the the suggestions! I made some changes in r153861. Please feel 
free to make further improvements to the Portfile since it is nomaintainer. 


Cheers!
Frank

> On Oct 13, 2016, at 8:35 AM, Ryan Schmidt <ryandes...@macports.org> wrote:
> 
> 
>> On Oct 12, 2016, at 4:23 PM, m...@macports.org wrote:
>> 
>> Revision
>> 153826
>> Author
>> m...@macports.org
>> Date
>> 2016-10-12 14:23:02 -0700 (Wed, 12 Oct 2016)
>> Log Message
>> 
>> ldns ldns-tools drill: Merge into single Portfile.
>> Modified Paths
>> 
>>      • trunk/dports/net/ldns/Portfile
>> Removed Paths
>> 
>>      • trunk/dports/net/drill/Portfile
>>      • trunk/dports/net/ldns-tools/Portfile
>> 
> 
> 
> 
>> --- trunk/dports/net/ldns/Portfile   2016-10-12 14:44:21 UTC (rev 153825)
>> +++ trunk/dports/net/ldns/Portfile   2016-10-12 21:23:02 UTC (rev 153826)
>> 
>> @@ -1,18 +1,35 @@
>> 
>> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
>> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>> 
>> # $Id$
>> 
>> 
>> 
>> -PortSystem 1.0
>> 
>> +PortSystem          1.0
>> 
>> 
>> 
>> name                ldns
>> 
>> +subport             ldns-tools {}
>> +subport             drill {}
>> +
>> 
>> version             1.6.17
>> 
>> categories          net devel
>> 
>> platforms           darwin
>> 
>> license             BSD
>> 
>> maintainers         nomaintainer
>> 
>> 
>> 
>> -description         DNS library in C
>> -long_description    ldns is a library with the aim of simplifying DNS \
>> -                    programming in C. It is heavily based upon the Net::DNS 
>> module from \
>> -                    Perl.
>> 
>> +if {${subport} eq "ldns"} {
>> +    description         DNS library in C
>> +    long_description    ldns is a library with the aim of simplifying DNS \
>> +                        programming in C. It is heavily based upon the 
>> Net::DNS module from \
>> +                        Perl.
>> +}
>> +if {${subport} eq "ldns-tools"} {
>> +    description         Tools for working with dns and dnssec.
>> +    long_description    Tools as examples to the ldns library. \
>> +                        Useful for debugging/querying dns/dnssec servers.
>> +}
>> +if {${subport} eq "drill"} {
>> +    description         A dig-style dnssec-aware dns debugging tool
>> +    long_description    Drill is a tool ala dig from BIND. \
>> +                        It was designed with DNSSEC in mind and should be a 
>> useful \
>> +                        debugging/query tool for DNSSEC.
>> +}
> 
> When comparing a single variable to several possible values, consider using a 
> switch statement.
> 
> Or, when making subports, consider putting the directives that relate to the 
> subport into the subport directive, rather than declaring an empty subport 
> directive which is a bit more confusing.
> 
> 
>> +if {${subport} ne "ldns"} {
>> +    distname            ldns-${version}
>> +    dist_subdir         ldns
>> +}
> 
> The default for distname is ${name}-${version} and the default for 
> dist_subdir is ${name} so now that these are subports in a main port named 
> ldns, these lines aren't necessary anymore.
> 
> 

_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to